Correct handling of Datasets #1845
Draft
+306
−196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Qup42
commented
Feb 28, 2025
Comment on lines
+2339
to
+2345
| expectDescribe( | ||
| "Describe ?x FROM <g> { ?x ?y ?z FILTER EXISTS {?a ?b ?c}}", | ||
| m::DescribeQuery( | ||
| m::Describe({Var("?x")}, {datasets, {}}, | ||
| m::SelectQuery(m::VariablesSelect({"?x"}, false, false), | ||
| filterGraphPattern, datasets)), | ||
| datasets)); |
There was a problem hiding this comment.
This test (and the equivalent one in SparqlParserTest) currently fail because the Select doesn't have the datasets set. This seems to be the desired behaviour (SparqlQleverVisitor.cpp::398):
NOTE: The dataset clauses are stored once in
parsedQuery_.datasetClauses_(which pertains to the CONSTRUCT query that computes the result of the DESCRIBE), and once inparsedQuery_.describeClause_.datasetClauses_(which pertains to the SELECT query that computes the resources to be described).
If that is so, then this note should be extended by this fact.
Comment on lines
+324
to
+330
| // TODO: is it a good idea to do this implicitly (the fields are nullopt) or | ||
| // should this be done explicitly (with a bool flag)? | ||
| if (!activeDatasetClauses_.defaultGraphs_.has_value() && | ||
| !activeDatasetClauses_.namedGraphs_.has_value()) { | ||
| activeDatasetClauses_ = parsedQuery::DatasetClauses::fromClauses(clauses); | ||
| } | ||
| return activeDatasetClauses_; |
|
Conformance check passed ✅No test result changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EXISTS) inSparqlAntlrParserTest`. Previously this was only tested indirectly in the QueryPlanerTest.Describematcher was changed slightly (it now matcherGraphPatternfor consistence with the other matchers).SparqlQleverVisitortakes the override dataset clause in its constructor and if these contain datasets then the datasets in the query are ignored.SparqlParserTest.TODO:
DESCRIBEcurrently fail, because the datasets are not set in its contained select (code comments seem to indicate that this should be set)